Skip to content

Added Support for Related Infrastructre Playbook and Workbook in Censys#13994

Open
devendra-chavda wants to merge 1 commit intoAzure:masterfrom
devendra-chavda:censys_support_for_related_infra
Open

Added Support for Related Infrastructre Playbook and Workbook in Censys#13994
devendra-chavda wants to merge 1 commit intoAzure:masterfrom
devendra-chavda:censys_support_for_related_infra

Conversation

@devendra-chavda
Copy link
Copy Markdown
Contributor

Change(s):

  • Added Support for Related Infrastructre Playbook and Workbook in Censys

Reason for Change(s):

  • Support for Related Infrastructre usecase

Version Updated:

  • No

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@devendra-chavda devendra-chavda requested review from a team as code owners April 6, 2026 09:08
@v-atulyadav v-atulyadav added Playbook Playbook specialty review needed Workbook Workbook specialty review needed Solution Solution specialty review needed labels Apr 6, 2026
@v-shukore v-shukore requested a review from Copilot April 8, 2026 05:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new “Related Infrastructure” experience to the Censys solution by wiring a new workbook section to a new playbook and custom table, plus updating supporting metadata and sample/test artifacts.

Changes:

  • Added a new “Related Infrastructure” dashboard section and ARM action trigger to the Censys workbook.
  • Added a new playbook reference + new custom table sample/test definitions for CensysRelatedInfrastructure_CL.
  • Updated workbook metadata assets list (new table + additional images) and appended release notes.

Reviewed changes

Copilot reviewed 10 out of 16 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
Workbooks/WorkbooksMetadata.json Updates Censys workbook metadata to reference the new custom table and additional images.
Solutions/Censys/Workbooks/Censys.json Adds a “Related Infrastructure” dashboard section, parameters, and KQL queries to drive the experience.
Solutions/Censys/ReleaseNotes.md Adds a release note entry for the new playbook/workbook support.
Solutions/Censys/Playbooks/CensysRelatedInfrastructure/README.md Adds documentation for deploying/configuring the new playbook.
Solutions/Censys/Package/createUiDefinition.json Updates package UI metadata (skipped review/comments per repo rules for Solutions/**/Package/**).
Solutions/Censys/Data/Solution_Censys.json Adds the new playbook ARM template to the solution manifest.
Sample Data/Custom/CensysRelatedInfrastructure_CL.csv Adds sample data for the new custom table.
Sample Data/Custom/CensysRelatedAssetsDetails_CL.csv Removes sample data for the previous related-assets table.
.script/tests/KqlvalidationsTests/CustomTables/CensysRelatedInfrastructure_CL.json Adds schema definition used by KQL validation tests for the new custom table.
.script/tests/KqlvalidationsTests/CustomTables/CensysRelatedAssetsDetails_CL.json Removes schema definition for the old custom table.

"durationMs": 86400000
},
"queryType": 1,
"resourceType": "microsoft.operationalinsights/workspaces",
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SubscriptionId parameter is configured as a Resource Graph query (queryType: 1) against the Resources table, but resourceType is set to microsoft.operationalinsights/workspaces (Log Analytics). This mismatch is likely to break the parameter query. Align resourceType with Resource Graph (for consistency with the ResourceGroup parameter) or change the query/queryType to match Log Analytics.

Suggested change
"resourceType": "microsoft.operationalinsights/workspaces",
"resourceType": "microsoft.resourcegraph/resources",

Copilot uses AI. Check for mistakes.
Comment on lines +1754 to +1770
"conditionalVisibilities": [
{
"parameterName": "SubscriptionId",
"comparison": "isNotEqualTo"
},
{
"parameterName": "ResourceGroup",
"comparison": "isNotEqualTo"
},
{
"parameterName": "IndicatorType",
"comparison": "isNotEqualTo"
},
{
"parameterName": "IndicatorValue",
"comparison": "isNotEqualTo"
}
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each conditionalVisibilities entry uses comparison: "isNotEqualTo" but omits the value to compare against. Workbook conditional visibility rules typically require a value (often "" to mean “not empty”). As-is, this can evaluate incorrectly or fail schema validation, causing the Submit link/panels to not appear as intended.

Copilot uses AI. Check for mistakes.
@@ -1,3 +1,4 @@
| **Version** | **Date Modified (DD-MM-YYYY)** | **Change History** |
|-------------|--------------------------------|--------------------------------------------------------------------|
| 3.0.0 | 06-04-2026 | Added Support for Related Infrastructre Playbook and Workbook |
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release notes table violates the required release notes format: it appears to have an extra leading empty column (|| ...), and it introduces a duplicate version (3.0.0 appears twice). Update the table to have exactly 3 columns (no leading empty column) and bump the solution version for this change (e.g., 3.0.1), keeping versions unique and ordered newest-first.

Suggested change
| 3.0.0 | 06-04-2026 | Added Support for Related Infrastructre Playbook and Workbook |
| 3.0.1 | 06-04-2026 | Added Support for Related Infrastructre Playbook and Workbook |

Copilot uses AI. Check for mistakes.
Comment on lines 1 to 4
| **Version** | **Date Modified (DD-MM-YYYY)** | **Change History** |
|-------------|--------------------------------|--------------------------------------------------------------------|
| 3.0.0 | 06-04-2026 | Added Support for Related Infrastructre Playbook and Workbook |
| 3.0.0 | 05-03-2026 | Initial Solution for Censys with Playbooks and Workbook |
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct spelling of "Infrastructre" to "Infrastructure".

Suggested change
| **Version** | **Date Modified (DD-MM-YYYY)** | **Change History** |
|-------------|--------------------------------|--------------------------------------------------------------------|
| 3.0.0 | 06-04-2026 | Added Support for Related Infrastructre Playbook and Workbook |
| 3.0.0 | 05-03-2026 | Initial Solution for Censys with Playbooks and Workbook |
| **Version** | **Date Modified (DD-MM-YYYY)** | **Change History** |
|-------------|--------------------------------|-------------------------------------------------------------------|
| 3.0.1 | 06-04-2026 | Added Support for Related Infrastructure Playbook and Workbook |
| 3.0.0 | 05-03-2026 | Initial Solution for Censys with Playbooks and Workbook |

Copilot uses AI. Check for mistakes.
@@ -1,3 +1,4 @@
| **Version** | **Date Modified (DD-MM-YYYY)** | **Change History** |
|-------------|--------------------------------|--------------------------------------------------------------------|
| 3.0.0 | 06-04-2026 | Added Support for Related Infrastructre Playbook and Workbook |
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR metadata says “Version Updated: No”, but the changes add functionality (new playbook/workbook support) and also add a new release note row. For Sentinel solutions, new content typically requires a version increment (and corresponding ReleaseNotes + Solution manifest alignment) rather than adding a second entry under the same version.

Copilot uses AI. Check for mistakes.
Comment on lines 13 to 17
"Playbooks/CensysHostHistory/azuredeploy.json",
"Playbooks/CensysIncidentEnrichment/azuredeploy.json",
"Playbooks/CensysIOCLookup/azuredeploy.json",
"Playbooks/CensysRelatedInfrastructure/azuredeploy.json",
"Playbooks/CensysRescan/azuredeploy.json"
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new playbook to the solution manifest should generally be accompanied by a solution version bump and consistent release notes entry for that bumped version (to ensure packaging/update flows can detect and distribute the new content correctly). Right now the release notes attempt to document the change under the existing 3.0.0, which is problematic.

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,45 @@
# Censys Ad-Hoc IOC Lookup
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README title doesn’t match the playbook being added (CensysRelatedInfrastructure) and can mislead users during deployment. Also, “Azure AD” is outdated terminology in Microsoft docs; consider updating to “Microsoft Entra ID” for consistency with current naming.

Copilot uses AI. Check for mistakes.
* PlaybookName: Enter the playbook name here (default: CensysRelatedInfrastructure).
* OrganizationID: Your Censys Organization ID from the Censys platform account settings.
* KeyVaultName: Name of the Azure Key Vault where the Censys API token is stored.
* TenantId: Azure AD Tenant ID where the Key Vault is located.
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README title doesn’t match the playbook being added (CensysRelatedInfrastructure) and can mislead users during deployment. Also, “Azure AD” is outdated terminology in Microsoft docs; consider updating to “Microsoft Entra ID” for consistency with current naming.

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,11 @@
TenantId,SourceSystem,MG,ManagementGroupName,"TimeGenerated [UTC]",Computer,RawData,"censys_url_s","count_d","fields_s","values_s","ioc_s","values_g",Type,"_ResourceId"
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSV header includes a UTF-8 BOM character before TenantId (visible as an extra character at the start). This can cause schema/parsing mismatches in tooling that expects exact column names; please remove the BOM so the first header is exactly TenantId.

Suggested change
TenantId,SourceSystem,MG,ManagementGroupName,"TimeGenerated [UTC]",Computer,RawData,"censys_url_s","count_d","fields_s","values_s","ioc_s","values_g",Type,"_ResourceId"
TenantId,SourceSystem,MG,ManagementGroupName,"TimeGenerated [UTC]",Computer,RawData,"censys_url_s","count_d","fields_s","values_s","ioc_s","values_g",Type,"_ResourceId"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playbook Playbook specialty review needed Solution Solution specialty review needed Workbook Workbook specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants